PKGNAME for non-default settings may change

[Boris Samorodov]

On Fri, 07 Dec 2007 22:56:37 -0500 Joe Marcus Clarke wrote:
> Boris Samorodov wrote:
> > On Fri, 07 Dec 2007 15:16:37 -0500 Joe Marcus Clarke wrote:
> >> Boris Samorodov wrote:
> > 
> >>> when building a package with non-default settings then a PKGNAME may
> >>> be changed from a default one. Ex., if one builds
> >>> editors/openoffice.org-2 with LOCALIZED_LANG="ru" then the package
> >>> name changes (a suffix "ru-" is added). But the recorded to a database
> >>> PKGNAME (and thus shown  at the web interface) stays a default one.
> > 
> >> This would be the case if the build and the makefile/database generation
> >> code are not in sync.  That should not be the case.
> > 
> > Actually, I didn't update tinderbox, just installed it from a port
> > and never tried to upgrade/update it. How can I verify that the build
> > and the makefile/database generation are at sync?

> Run ./tc addPort on your port with your custom settings defined, and
> check the database.  If the PKGNAME is not correct, then that needs to
> be looked at.

Joe, thanks for your suggestion.

Seems that I found the culprit. The package name is defined at
makemake (line 194):
-----
$pkgname = $makecache->PkgName($portdir);     [1]
-----

Looking at it deeper I found that the value is defined at finction
_execMake file lib/MakeCache.pm (line 58). Apparently this function
doesn't trace custom variables from *.env.

If I manually assign the needed name to $pkgname at [1]
(i.e. $pkgname = 'ru-openoffice.org-2.0.1') then everything go fine:
the Makefile at $tb/builds/$build, the log name (URL), the package
file (URL) point to the right files and the column 'Version' at web
pages contains the right version (i.e. with 'ru-' prefix).


WBR
-- 
Boris Samorodov (bsam)
Research Engineer, http://www.ipt.ru Telephone & Internet SP
FreeBSD committer, http://www.FreeBSD.org The Power To Serve