ports-mgmt/tinderbox

[Joe Marcus Clarke]

On 11/2/11 2:09 PM, Ion-Mihai Tetcu wrote:
> 
>  [ tindy list CC'ed ]
> 
> On Wed, 2 Nov 2011 11:55:36 +0000
> Tim Bishop <tim at bishnet.net> wrote:
> 
>> On Wed, Nov 02, 2011 at 12:22:43PM +0200, Ion-Mihai Tetcu wrote:
>>>> Just a few quick questions about the tinderbox port.
>>>>
>>>> 1. Could you make the install directory configurable? Maybe set a
>>>> make variable to default to ${PREFIX}/tinderbox, but allow it to
>>>> be overridden? I ask because I use a separate filesystem for
>>>> tinderbox, so at the moment I rsync it across every time I update
>>>> the port, which is a bit of a pain.
>>>
>>> So basically what you want is for the man pages and rc.d script to
>>> go to /usr/local/...... but 
>>> - ${CP} -R ${WRKSRC}/* ${PREFIX}/tinderbox/scripts
>>> + ${CP} -R ${WRKSRC}/* ${TBDIR}/tinderbox/scripts
>>> with the appropiate change to the rc.d script?
>>
>> Yes. Although I guess a little more like this:
>>
>> TBDIR?= ${PREFIX}/tinderbox
> 
> :-) of course, I was just writing in a hurry.
> 
>> ${CP} -R ${WRKSRC}/* ${TBDIR}/scripts
>>
>> I hadn't thought about man pages, but obviously they and the rc.d
>> script should stay where they are. It's just ${PREFIX}/tinderbox that
>> I'd like configurable.
> 
> Yep.
>  
>>>> 2. I installed a clean 3.4 on a new machine. When I ran the setup
>>>> it complained that archivers/p5-Compress-Bzip2 wasn't installed.
>>>> Should it be a dependency?
>>>
>>> That should actually be optional, it's only needed if you enable log
>>> compression. I'll add it to the ports as a RUN_DEPENDS via an
>>> OPTION. This is already done in -devel, but miwi@ missed to merge
>>> it in the main port when he committed the update (and I'll spank
>>> him for it).
>>
>> Hmm. Understood. But, maybe "tc Setup" shouldn't complain about it not
>> being there if it's optional? It doesn't seem quite right installing
>> the port then the setup script saying something is missing...
> 
> Yeh, the message would be better " ... needed for optional log
> compressing" ...
> 
>>>> 3. Talking of tinderbox-devel, do you have any plans to bring
>>>> across the extra patches you have there? The parallel one is the
>>>> main one I'd like to see (since I'm patching that locally at the
>>>> moment), but the tmpfs one sounds interesting too.
>>>
>>> Hmm, not really. I consider them both experimental:
>>> - the tmpfs has problems (not the patch, the kernel).
>>> - the parallel seems to be in better shape, but I don't have clear
>>>   reports that it works without any problem.
>>>
>>> The way to go would be to merge them upstream, which I can do for
>>> the parallel patch, if you can confirm it doesn't give you any
>>> problems after running heavily with it for a week or two.
>>
>> I've been using the parallel patch for years (I wrote it), but at the
>> time I'm not sure enough other people tested it to confirm it was
>> worthy of being merged. That's why I suggested adding it to the port
>> since it makes it optional.
> 
> ping anyone   :)

If the patch is tested and others find it useful, it could be merged.
Where is this patch again?

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc